[Openinteract-dev] Removing of get_current from Request?

[Heiko Klein]

Why is there the get_current function in Request in OI2 1.99_05? As the
documentation says, the current request can be fetched by CTX->request
or OI2::Request->get_current.

get_current is not implemented for Request/Apache.pm and
Request/Apache2.pm, and the implementation for CGI, LWP and Standalone
might give different results from CTX->request when switching the
implementation (its stored in the implementation class).

I had some problems while debugging because of this double store of
request. Is a patch welcome?

Best regards,

Heiko

[Chris Winters]

Post by Heiko Klein
Why is there the get_current function in Request in OI2 1.99_05? As
the documentation says, the current request can be fetched by
CTX->request or OI2::Request->get_current.
get_current is not implemented for Request/Apache.pm and
Request/Apache2.pm, and the implementation for CGI, LWP and Standalone
might give different results from CTX->request when switching the
implementation (its stored in the implementation class).

I think it was a pre-emptive "let's see if this will work" for running
under threaded environments. But now I really don't know, and I don't
think it's needed anymore.

Post by Heiko Klein
I had some problems while debugging because of this double store of
request. Is a patch welcome?

I'll get rid of this:

http://jira.openinteract.org/browse/OIN-82

Thanks,

Chris

--
Chris Winters
Creating enterprise-capable snack systems since 1988